refactor: clean up clippy lints

.github/workflows/lint.yaml

@@ -56,13 +56,7 @@ jobs:
               run: rustup component add clippy rustfmt
 
             - name: cargo clippy
-              run: >-
+              run: cargo clippy -- -D clippy::pedantic
-                  cargo clippy -- -D clippy::pedantic
-                  -A clippy::missing_errors_doc
-                  -A clippy::missing_panics_doc
-                  -A clippy::must_use_candidate
-                  -A clippy::needless-pass-by-value
-                  -A clippy::unnecessary-wraps
 
             - name: cargo fmt
               if: always()

src/lua/client/mod.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::needless_pass_by_value, clippy::unnecessary_wraps)]
+
 mod container;
 mod interaction;
 mod movement;

src/lua/container/click.rs

@@ -4,7 +4,7 @@ use azalea::inventory::operations::{
 };
 use mlua::{Result, Table};
 
-pub fn operation_from_table(op: Table, op_type: Option<u8>) -> Result<ClickOperation> {
+pub fn operation_from_table(op: &Table, op_type: Option<u8>) -> Result<ClickOperation> {
     Ok(match op_type.unwrap_or_default() {
         0 => ClickOperation::Pickup(PickupClick::Left {
             slot: op.get("slot")?,

src/lua/container/mod.rs

@@ -30,7 +30,7 @@ impl UserData for Container {
             "click",
             |_, this, (operation, operation_type): (Table, Option<u8>)| {
                 this.0
-                    .click(operation_from_table(operation, operation_type)?);
+                    .click(operation_from_table(&operation, operation_type)?);
                 Ok(())
             },
         );
@@ -66,7 +66,7 @@ impl UserData for ContainerRef {
             "click",
             |_, this, (operation, operation_type): (Table, Option<u8>)| {
                 this.0
-                    .click(operation_from_table(operation, operation_type)?);
+                    .click(operation_from_table(&operation, operation_type)?);
                 Ok(())
             },
         );

src/replay/plugin.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::needless_pass_by_value)]
+
 use super::recorder::Recorder;
 use azalea::{
     ecs::{event::EventReader, system::Query},