ci: add build and lint workflows

.github/workflows/build.yaml

@@ -0,0 +1,37 @@
+name: Build
+on:
+    push:
+        paths:
+            - "**.rs"
+            - "Cargo.*"
+    pull_request:
+    workflow_dispatch:
+
+jobs:
+    errornowatcher:
+        name: errornowatcher
+        runs-on: ubuntu-24.04
+
+        steps:
+            - name: Clone repository
+              uses: actions/checkout@v4
+
+            - name: Install build dependencies
+              run: sudo apt install -y libluajit-5.1-dev mold
+
+            - name: Set up build cache
+              uses: actions/cache@v4
+              with:
+                  path: |
+                      ~/.cargo/bin/
+                      ~/.cargo/registry/index/
+                      ~/.cargo/registry/cache/
+                      ~/.cargo/git/db/
+                      target/
+                  key: build-${{ runner.os }}-${{ hashFiles('Cargo.*') }}
+
+            - name: Switch to nightly toolchain
+              run: rustup default nightly
+
+            - name: Build in release mode
+              run: cargo build --release

.github/workflows/lint.yaml

@@ -0,0 +1,68 @@
+name: Lint
+on:
+    push:
+        paths:
+            - "**.rs"
+            - "Cargo.*"
+    pull_request:
+    workflow_dispatch:
+
+jobs:
+    cargo-toml:
+        name: Cargo.toml
+        runs-on: ubuntu-24.04
+
+        steps:
+            - name: Clone repository
+              uses: actions/checkout@v4
+
+            - name: Install taplo
+              uses: uncenter/setup-taplo@v1
+
+            - name: Run taplo lint
+              run: taplo lint Cargo.toml
+
+            - name: Run taplo fmt
+              if: always()
+              run: taplo fmt --check Cargo.toml
+
+    rust:
+        name: Rust
+        runs-on: ubuntu-24.04
+
+        steps:
+            - name: Clone repository
+              uses: actions/checkout@v4
+
+            - name: Install build dependencies
+              run: sudo apt install -y libluajit-5.1-dev mold
+
+            - name: Set up build cache
+              uses: actions/cache@v4
+              with:
+                  path: |
+                      ~/.cargo/bin/
+                      ~/.cargo/registry/index/
+                      ~/.cargo/registry/cache/
+                      ~/.cargo/git/db/
+                      target/
+                  key: build-${{ runner.os }}-${{ hashFiles('Cargo.*') }}
+
+            - name: Switch to nightly toolchain
+              run: rustup default nightly
+
+            - name: Install components
+              run: rustup component add clippy rustfmt
+
+            - name: cargo clippy
+              run: >-
+                  cargo clippy -- -D clippy::pedantic
+                  -A clippy::missing_errors_doc
+                  -A clippy::missing_panics_doc
+                  -A clippy::must_use_candidate
+                  -A clippy::needless-pass-by-value
+                  -A clippy::unnecessary-wraps
+
+            - name: cargo fmt
+              if: always()
+              run: cargo fmt --check

src/replay/plugin.rs

@@ -22,19 +22,15 @@ pub struct RecordPlugin {
 impl Plugin for RecordPlugin {
     fn build(&self, app: &mut bevy_app::App) {
         if let Some(recorder) = self.recorder.lock().take() {
-            app.insert_resource(recorder);
+            app.insert_resource(recorder)
-        }
+                .add_systems(First, record_login_packets.before(process_packet_events))
-        app.add_systems(First, record_login_packets.before(process_packet_events))
                 .add_systems(First, record_configuration_packets)
                 .add_systems(First, record_game_packets.before(send_packet_events));
         }
+    }
 }
 
-fn record_login_packets(
+fn record_login_packets(mut recorder: ResMut<Recorder>, mut events: EventReader<LoginPacketEvent>) {
-    recorder: Option<ResMut<Recorder>>,
-    mut events: EventReader<LoginPacketEvent>,
-) {
-    if let Some(mut recorder) = recorder {
     for event in events.read() {
         if recorder.should_ignore_compression
             && let ClientboundLoginPacket::LoginCompression(_) = *event.packet
@@ -46,26 +42,21 @@ fn record_login_packets(
             error!("failed to record login packet: {error:?}");
         }
     }
-    }
 }
 
 fn record_configuration_packets(
-    recorder: Option<ResMut<Recorder>>,
+    mut recorder: ResMut<Recorder>,
     mut events: EventReader<ConfigurationEvent>,
 ) {
-    if let Some(mut recorder) = recorder {
     for event in events.read() {
         if let Err(error) = recorder.save_packet(&event.packet) {
             error!("failed to record configuration packet: {error:?}");
         }
     }
-    }
 }
 
-fn record_game_packets(recorder: Option<ResMut<Recorder>>, query: Query<&RawConnection>) {
+fn record_game_packets(mut recorder: ResMut<Recorder>, query: Query<&RawConnection>) {
-    if let Some(mut recorder) = recorder
+    for raw_conn in query.iter() {
-        && let Ok(raw_conn) = query.get_single()
-    {
         let queue = raw_conn.incoming_packet_queue();
         for raw_packet in queue.lock().iter() {
             if let Err(error) = recorder.save_raw_packet(raw_packet) {