Fixed a bug where comments could be submitted without any content

and where the hitcount was incremented before the program checked if
the post existed

src/routes/form_actions.js

@@ -19,21 +19,25 @@ router.post("/submit_comment", (req,res) => {
     const postID = parseInt(req.body.post_index)
     const content = func.escape_input(req.body.content)
     let name = func.escape_input(req.body.name)
-    if (name == "") {
+    // Give the user the default username if they left that bit blank
+    if (name == "" || typeof name == 'undefined') {
         name = config.default_commenter_username
     }
 
-    let comments = data.getdata('comments')
+    // Check there is actually content in the comment
+    if (content != '' && typeof content != 'undefined') {
+	    let comments = data.getdata('comments')
 
-    new_comment = {
-        "name": name,
-        "content": content,
-         "id": comments[postID].length,
-         "pubdate": unix_timestamp,
-         "postID": postID,
-    };
-    comments[postID].push(new_comment);
-    fs.writeFileSync(`../data/comments.json`, `${JSON.stringify(comments)}`, 'utf-8');
+	    new_comment = {
+		"name": name,
+		"content": content,
+		 "id": comments[postID].length,
+		 "pubdate": unix_timestamp,
+		 "postID": postID,
+	    };
+	    comments[postID].push(new_comment);
+	    fs.writeFileSync(`../data/comments.json`, `${JSON.stringify(comments)}`, 'utf-8');
+    }
 
     res.redirect(301,`/post/${req.body.post_index}`)
 }); // /submit_comment

src/routes/standard_pages.js

@@ -62,15 +62,15 @@ router.get("/user/:username", (req, res) => {
 router.get("/post/:post_index", (req, res) => {
     const postID = parseInt(req.params.post_index)
     let post = data.getdata('posts', postID)
-    if (config.enable_hitcount) {
-	data.increment_hitcount(postID)
-    }
     if (post == 1) { // data.getdata returns error code 1 if nothing is available
         res.render("partials/message", {
             message: locale.post_doesnt_exist,
             config,
         })
     }
+    if (config.enable_hitcount) {
+	data.increment_hitcount(postID)
+    }
     else if (typeof post["deleted"] == "undefined" || post["deleted"] == false) {
         res.render("pages/post",
                    {