From 4f18c547f7612e7628b8ded3a9a7166a4c07a975 Mon Sep 17 00:00:00 2001 From: mushahidq Date: Thu, 15 Oct 2020 00:53:51 +0530 Subject: [PATCH] Fixed useless parameters on Multiplication --- mathgenerator/mathgen.py | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/mathgenerator/mathgen.py b/mathgenerator/mathgen.py index 0931109..79d5510 100644 --- a/mathgenerator/mathgen.py +++ b/mathgenerator/mathgen.py @@ -36,9 +36,16 @@ def subtractionFunc(maxMinuend = 99, maxDiff = 99): return problem, solution def multiplicationFunc(maxRes = 99, maxMulti = 99): - a = random.randint(0, maxMulti) - b = random.randint(0, min(maxRes, maxMulti)) - c = a*b + c = random.randint(0, maxMulti) # Generate the solution to the problem + i = int(1) + j = 0 #Indices for the loop + d = [] #Array to store the factors + while(i<=c): #Factors are less than or eqaul to the number + if(c%i == 0): #If the remainder is 0, the number is a factor + d[j] = i #Store the factor + j += 1 #Move to the next index + a = random.randint(0, c) #Generate a multiplicant + b = c/a #Find the other multiplicant problem = str(a) + "*" + str(b) + "=" solution = str(c) return problem, solution