From 82015bf4d5eb74ad0c1daba4a58392429716250e Mon Sep 17 00:00:00 2001 From: Sankari Karthik <92105177+Sankari-K@users.noreply.github.com> Date: Sat, 9 Oct 2021 15:55:13 +0530 Subject: [PATCH] Update percentage_error.py --- mathgenerator/funcs/basic_math/percentage_error.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/mathgenerator/funcs/basic_math/percentage_error.py b/mathgenerator/funcs/basic_math/percentage_error.py index 32b9067..41c0b20 100644 --- a/mathgenerator/funcs/basic_math/percentage_error.py +++ b/mathgenerator/funcs/basic_math/percentage_error.py @@ -4,9 +4,12 @@ from .__init__ import * def gen_func(maxValue=100, minValue=-100, format='string'): observed_value = random.randint(minValue, maxValue) exact_value = random.randint(minValue, maxValue) - - error = (abs(observed_value - exact_value)/abs(exact_value))*100 - error = round(error,2) + + if observed_value * exact_value < 0: + observed_value *= -1 + + error = (abs(observed_value - exact_value) / abs(exact_value)) * 100 + error = round(error, 2) if format == 'string': problem = f"Find the percentage error when observed value equals {observed_value} and exact value equals {exact_value}." @@ -20,5 +23,6 @@ def gen_func(maxValue=100, minValue=-100, format='string'): return observed_value, exact_value, error -percentage_error = Generator("Percentage error", , gen_func, - ["maxValue=100", "minValue=-100"]) +percentage_error = Generator( + "Percentage error", , gen_func, + ["maxValue=100", "minValue=-100"])